Builder debian11-1.12 Build #65

Results:

Build successful

SourceStamp:

BuildSlave:

Reason:

The SMScheduler scheduler named 'sched-master' triggered this build

Steps and Logfiles:

1. git update ( 1 secs )
   1. stdio
2. bootstrap bootstrapped ( 5 secs )
   1. stdio
3. build compiled ( 2 mins, 43 secs )
   1. stdio
4. upload uploaded ( 16 secs )
   1. stdio

Build Properties:

Forced Build Properties:

Responsible Users:

1. Oliver John Hitchcock

   ojhitchcockohnoyoudont@gmail.com

Timing:

All Changes:

:

1. Change #5564

   Category	None
   Changed by	Oliver John Hitchcock <ojhitchcockohnoyoudont@gmail.com>
   Changed at	Thu 25 Apr 2024 16:19:04
   Repository	https://github.com/alliedmodders/sourcemod
   Project	alliedmodders/sourcemod
   Branch	master
   Revision	f9ad35badf2effb36cdaadb4fd990ef3a1b012e4

   Comments

   Stop EntRefToEntIndex returning garbage if a bad parameter is passed (#1323)
   
   * Stop EntRefToEntIndex returning garbage if a bad parameter is passed
   
   Seen multiple bad usage of this function that works only because whatever was passed in was returned as it wasnt an entity reference.
   This code should have worked and would be expected to have returned something invalid but instead the the input was returned which allowed the code to work when really it is bad code.
   See for one such case https://discordapp.com/channels/335290997317697536/335290997317697536/736518488314871868
   
   * Update documentation of EntRefToEntIndex
   
   Added the error text saying what shall be returned when a invalid parameter is passed.
   
   * Validate entity index instead of just returning INVALID_EHANDLE_INDEX
   
   Not sure if it needs this much validation but this just mirrors how IsValidEntity works, so the entity index returned should be valid else INVALID_EHANDLE_INDEX is returned.
   
   * EntRefToEntIndex improve doc comments to better represent functionality
   
   ---------
   
   Co-authored-by: Kyle Sanderson <[email protected]>

   Changed files

   • core/HalfLife2.cpp
   • plugins/include/halflife.inc